Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize line endings before signature validation #498

Merged
merged 1 commit into from
Nov 5, 2020
Merged

normalize line endings before signature validation #498

merged 1 commit into from
Nov 5, 2020

Conversation

mhassan1
Copy link
Contributor

@mhassan1 mhassan1 commented Nov 5, 2020

Description

Resolves #431

Checklist:

  • Issue Addressed: [X]
  • Link to SAML spec: [ ]
  • Tests included? [X]
  • Documentation updated? [ ]

@mhassan1 mhassan1 mentioned this pull request Nov 5, 2020
Closed
@cjbarth cjbarth added the semver-patch This change requires at least a semver-patch version bump label Nov 5, 2020
@markstos
Copy link
Contributor

markstos commented Nov 5, 2020

According to the research I did earlier on how the spec says to handle newlines, this appears correct. Merging.

@markstos markstos merged commit 02c6c5a into node-saml:master Nov 5, 2020
@mhassan1
Copy link
Contributor Author

mhassan1 commented Nov 5, 2020

Will this be backported to 1.x?

@markstos
Copy link
Contributor

markstos commented Dec 4, 2020

No.

@mhassan1 mhassan1 mentioned this pull request Dec 11, 2020
Closed
@cjbarth cjbarth mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjbarth cjbarth cjbarth approved these changes

Assignees
No one assigned
Labels
semver-patch This change requires at least a semver-patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"invalid signature" when using xml-crypto > 1.4.0
3 participants
@mhassan1 @markstos @cjbarth