NameIDFormat fix #375
Merged
NameIDFormat fix #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a conditional statement to set NameIDFormat only if identifierFormat is specified in options. This should prevent an error in AD FS when identifierFormat set to null: node-saml#338
|
@sibelius This look OK to me. What do you think? |
sibelius
approved these changes
Jul 26, 2019
walokra
pushed a commit
to vrk-kpa/suomifi-passport-saml
that referenced
this pull request
Sep 16, 2019
* upstream: bump version to 1.2.0 Use exact match to check for a compatible crypto algorithm. Validate signatures on original query string NameIDFormat fix (node-saml#375) Remove InResponseTo value if response validation fails v1.1.0: bump for release # Conflicts: # lib/passport-saml/saml.js # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#338
When identifierFormat: null the passport-saml generated metadata with a tag
<NameIDFormat/>which causes an error in AD FS:The value 'NameIDFormat' must be an absolute URI.Setting the identifierFormat: urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified allows importing the metadata file successfully.