Set explicitChar: true to make XML parsing consistent. Fixes issue #283 and #187 #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… element should be accessed only through ._
cjbarth
approved these changes
Mar 7, 2019
markstos
changed the title
|
The Thanks. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting explicitChars to true whenever xml2js is used and always use ._ to access values incosistent checks for [0] and [0]._ are eliminated.
Not broken test that were not broken from before.
Could have set .$ and ._ to .attrs and .chars or something instead but to fix the inconsistensies in the issues this was not necessary.