Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple certificates in light of IdP cert rotation. Addresse… #204

Closed
wants to merge 2 commits into from

Conversation

austburn
Copy link

…s #189

@austburn
Copy link
Author

Curious on thoughts of how this might look.

Some of my thoughts that went into this:

  • I didn't want a breaking change, therefore leaving cert alone
  • I didn't want to introduce type fluidity with allowing cert to be an array or string
  • I figured a single alternate certificate would do

I think all of the above can be contested but figured this might be a good starting point.

Copy link

@j00k j00k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@austburn
Copy link
Author

austburn commented May 2, 2017

@ploer any feedback on this?

@j00k
Copy link

j00k commented May 17, 2017

Is there an official maintainer for this project @bergie ?

@ghost
Copy link

ghost commented Aug 5, 2017

@bergie Can we get this merged and released? I know of projects running passport-saml with a fork including @austburn's changes, Im sure other passport-saml consumers would benefit from this change.

@jaustinpage
Copy link

@bergie any updates on this? We could really benefit from this...

@markstos
Copy link
Contributor

markstos commented Jan 3, 2018

Closing this, as alternate solution was implemented in #218

@markstos markstos closed this Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants