Error: Invalid signature

[huineng]

Could you please tell me what breaking change you have introduced since i've upgraded to 1.0.0 from 0.35.0 ?

this package was running correctly since several months until this release update.
i have no clue what has changes or what caused this

thanks

Error: Invalid signature
    at /home/app/node_modules/passport-saml/lib/passport-saml/saml.js:609:15
    at _fulfilled (/home/app/node_modules/q/q.js:854:54)
    at self.promiseDispatch.done (/home/app/node_modules/q/q.js:883:30)
    at Promise.promise.promiseDispatch (/home/app/node_modules/q/q.js:816:13)
    at /home/app/node_modules/q/q.js:624:44
    at runSingle (/home/app/node_modules/q/q.js:137:13)
    at flush (/home/app/node_modules/q/q.js:125:13)
    at process._tickCallback (internal/process/next_tick.js:176:11)

[huineng]

I guess the reason is the crypto-xml upgrade see node-saml/xml-crypto#158 and node-saml/xml-crypto#164

[LoneRifle]

Hi, passive maintainer for xml-crypto here. Would you be able to isolate a test case involving only xml-crypto for me to look further into? Thanks!

[huineng]

got it solved node-saml/xml-crypto#167

[phof]

I had the same issue after upgrading to passport-saml 1.0.0; downgrading to xml-crypto 0.10.1 solved it.

"resolutions": {
  "passport-saml/xml-crypto": "0.10.1"
}

cc/ @huineng @LoneRifle @markstos FYI

[christiaanwesterbeek]

I had the same issue with passport-saml 1.0.0 and I can confirm that adding this to package.json fixed the problem.

"resolutions": {
  "passport-saml/xml-crypto": "0.10.1"
}

And the following does not

"resolutions": {
  "passport-saml/xml-crypto": "1.1.1"
}

[LoneRifle]

Hello @christiaanwesterbeek @phof - could I trouble either of you to test this against 1.0.1 of xml-crypto to see if that works? The cause of the issue might be down to what @huineng raised in node-saml/xml-crypto#167 ; I just want someone to confirm this is the case.

If you can also confirm that the fix @huineng proposed there would resolve the issue, I'll take a PR.

[christiaanwesterbeek]

@LoneRifle I just tested it. A resolution with 1.0.1 of xml-crypto works too. I've looked into trying what @huineng proposed in node-saml/xml-crypto#167 . Unfortunately It's not enough info for me. I'll elaborate a bit over there...

[phof]

@LoneRifle Confirmed xml-crypto 1.0.1 works; I'll take a look at node-saml/xml-crypto#167

[LoneRifle]

Let's continue the discussion there.

[netmastan]

Hi Team, I did not meant to yelling. My apologies If it is taken that way. Thanks for all the hardwork and excellent module. Regards

…

On Sat, 9 Feb 2019 at 10:58 PM, Mark Stosberg ***@***.***> wrote: @paglasoft <https://github.com/paglasoft> yelling in a headline style is not welcome. You *are* welcome to pay someone to look into your issue or use a different module if you can't resolve it yourself. Yelling at the volunteers helping to maintain this module is counterproductive. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#324 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ArQbrlk-xGehp_YjJWw_0RyETtVtF4feks5vLrfPgaJpZM4ZAZKV> .