Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify signing vs encryption cert in README #170

Closed
markstos opened this issue Sep 14, 2016 · 0 comments
Closed

clarify signing vs encryption cert in README #170

markstos opened this issue Sep 14, 2016 · 0 comments

Comments

@markstos
Copy link
Contributor

From the README docs:

you can provide the Identity Provider's certificate using the cert

It would be helpful to clarify whether it's the IDP's signing certificate or encrypting certificate in the case where there are both. Based on the paragraph above this sentence in the same document, I'm guessing it's the signing certificate.

markstos added a commit to markstos/passport-saml that referenced this issue Sep 14, 2016
1. public, not private
2. a signing certificate and not an encryption certificate
pdspicer added a commit that referenced this issue Mar 31, 2017
Fixes #170: Clarify that the certificate are looking for is:
cjbarth added a commit to cjbarth/passport-saml that referenced this issue Sep 10, 2018
…-string-signing

* commit '4d97ffcb7918526cfc6101207fe04d14a0abd23e':
  README: link to related sections and clarify decryptionCert docs
  Update deps to latest
  Updated README to include sha512 as a listed option
  Remove unused ejs package from devDeps
  Use latest version of xml-encryption
  Fixes node-saml#170: Clarify that the certificate are looking for is:
  Add the ability to sign with SHA-512
  Fix tests on Node.js:stable
  Add test for an encrypted Okta response
  Send EncryptedAssertion node when trying to decrypt the assertion
  Updagrade to xml-encryption 0.9
  Fix tests with latest version of shouldjs
  v0.15.0
cjbarth added a commit to cjbarth/passport-saml that referenced this issue Sep 10, 2018
…url-params

* commit '6d1215bf96e9e352c25e92d282cba513ed8e876c':
  Update deps to latest
  Updated README to include sha512 as a listed option
  Remove unused ejs package from devDeps
  Use latest version of xml-encryption
  Fixes node-saml#170: Clarify that the certificate are looking for is:
  Add the ability to sign with SHA-512
  Fix tests on Node.js:stable
  Add test for an encrypted Okta response
  Send EncryptedAssertion node when trying to decrypt the assertion
  Updagrade to xml-encryption 0.9
  Fix tests with latest version of shouldjs

# Conflicts:
#	test/samlTests.js
cjbarth added a commit to cjbarth/passport-saml that referenced this issue Sep 11, 2018
…-authn-context

* commit '6d1215bf96e9e352c25e92d282cba513ed8e876c':
  Update deps to latest
  Updated README to include sha512 as a listed option
  Remove unused ejs package from devDeps
  Use latest version of xml-encryption
  Fixes node-saml#170: Clarify that the certificate are looking for is:
  Add the ability to sign with SHA-512
  Fix tests on Node.js:stable
  Add test for an encrypted Okta response
  Send EncryptedAssertion node when trying to decrypt the assertion
  Updagrade to xml-encryption 0.9
  Fix tests with latest version of shouldjs

# Conflicts:
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant