Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
Change attributeName to unknown type to allow for use-case described in DefinitelyTyped/DefinitelyTyped#33950. For example, you may extend the Profile object with an attribute `roles` which is an array of string. Having unknown still allows for typing enforcement, and yet is flexible to allow for these use-cases
  • Loading branch information
josecolella authored and markstos committed Mar 18, 2019
1 parent b99deb1 commit 663c127
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ type Profile = {
getSamlResponseXml(): string; // get the raw SAML response XML
ID?: string;
} & {
[attributeName: string]: string; // arbitrary `AttributeValue`s
[attributeName: string]: unknown; // arbitrary `AttributeValue`s
}
```
Expand Down

0 comments on commit 663c127

Please sign in to comment.