Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of tabulator.min.css to enable #36

Merged
merged 7 commits into from
Jul 18, 2020
Merged

Conversation

Christian-Me
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

as mentioned here https://discourse.nodered.org/t/ui-table-options-how-example-no-header/30252/3?u=christian-me
and discussed with @dceejay

Proposed changes

Upgraded tabulator.min.css to 4.5 which contain the necessary css class to hide the column header.
Small bugfix: The autoColumns property should be set to false if the table is configured through ui_control. Feature was broken through 0.3.2

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Christian-Me
Copy link
Contributor Author

Sorry I messed up my repro .. (again) I always forget A) to create a branch before doing any changes and b) get my local copy "in sync" after a PR is merged (never found out how to do this the best way)

Hope this workes - hand edited all conflicts.

@dceejay dceejay merged commit 9d14220 into node-red:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants