Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and support for npm >= 7 fixes #123 #127

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Conversation

deepy
Copy link
Member

@deepy deepy commented Nov 27, 2020

This adds a simple test for npm and yarn that checks that installation works on npm 7 and greater.

It's download = true to make sure that we run on new enough versions.

@deepy
Copy link
Member Author

deepy commented Nov 28, 2020

windows (pull_request) succeeded in 336m and windows (push) failed after 316m.

I think we might have to consider running less tests on windows, maybe having just MINIMUM_SUPPORTED_GRADLE_VERSION and CURRENT_GRADLE_VERSION which would hopefully cut about 2 hours from the build process.

@deepy deepy merged commit 9f5daed into master Nov 30, 2020
@deepy deepy deleted the npm-7plus-tests branch November 30, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant