Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add code and http code to most errors #686

Merged
merged 4 commits into from
Feb 16, 2021

Conversation

GrosSacASac
Copy link
Contributor

No description provided.

@lmammino
Copy link

Left some minor comments regarding how to encode errors. I really like this new feature btw :)

@GrosSacASac GrosSacASac merged commit 8a74c8a into master Feb 16, 2021
@GrosSacASac GrosSacASac deleted the feat-add-code-and-httpCode-to-most-errors branch February 16, 2021 19:02
@tunnckoCore
Copy link
Member

I like this too! Good job.

Minor thing is that I would like more the internal codes to be hardcoded and maybe start from 1000, not from zero.

@GrosSacASac
Copy link
Contributor Author

done cd9edd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants