Fix llama 8b fp8 benchmarking test #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
aviator19941
force-pushed
the
fix_8b_fp8_benchmarking_test
branch
from
8b2e83c to
533d4c9
Compare
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
| self.artifacts_dir_2048 = Path("/shark-dev/8b") | ||
| self.irpa_path = self.artifacts_dir / "fp16/llama3.1_8b_fp16.irpa" | ||
| self.irpa_path_fp8 = self.artifacts_dir / "f8/llama3.1_8b_fp8.irpa" | ||
| self.artifacts_dir = Path("/shark-dev/8b") |
There was a problem hiding this comment.
Do we have a separate PR to update the 70B/405B instruct paths as well?
There was a problem hiding this comment.
yeah will be a separate PR
archana-ramalingam
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking test for fp8 was failing the Export phase, but was expected to fail for the Benchmarking phase and was getting killed.