Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sharktank][Llama][FP8] Minimal changes for numerically correct fp8 #859

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Sharktank][Llama][FP8] Minimal changes for numerically correct fp8 #859

wants to merge 2 commits into from

Conversation

dan-garvey
Copy link
Member

TBAdded

@dan-garvey dan-garvey force-pushed the users/dan_garvey/fp8_staging branch 3 times, most recently from e6204fd to f33b6af Compare January 24, 2025 00:26
@dan-garvey
stash pop
f33b6af 
temp

remove cast to f32

temp

temp

working using llama embed

passes numerics and compiles

seven flavors of absolute trash

make decode great again

guard no mask

first round cleanup
@dan-garvey
fix rms norm again
1d793fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dan-garvey