Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attention + enable VMMA #43

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Fix attention + enable VMMA #43

merged 2 commits into from
Jan 23, 2025

Conversation

raikonenfnu
Copy link
Member

Update attention to work ToM and support VMMA:

  1. Update translation info to use "pipeline"
  2. Update attention IREE IR to specify QK and KV MMA schedule separately S.T it works with ToM IREE
  3. Refactor to use enum.Enum to represent intrinsics
  4. Add VMMA support and helper functions to maximize perf

saienduri and others added 2 commits January 22, 2025 17:23
@saienduri @raikonenfnu
attribute change
6129b48
@raikonenfnu
Update attention to work ToM and support VMMA
91b2557 
1. Update attention IREE IR to specify QK and KV MMA schedule separately
   S.T it works with ToM IREE
2. Refactor to use enum.Enum to represent intrinsics
3. Add VMMA support and helper functions to maximize perf

Signed-off-by: Stanley Winata <stanley.winata@amd.com>
@raikonenfnu raikonenfnu requested a review from saienduri January 23, 2025 02:42
saienduri
saienduri approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@saienduri saienduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@raikonenfnu raikonenfnu merged commit 87c0c8c into nod-ai:main Jan 23, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saienduri saienduri saienduri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raikonenfnu @saienduri