-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TKW gemm tests #36
Conversation
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Thanks for the fixes Ivan! Is it possible to stick with generate TK mlir and then go through the normal compilation flow? It would be great if we can limit branching off from the general flow only when necessary. This allows us to scale and build an overall clean pipeline and helps also on visibility of how we are compiling (flags, commands, etc) |
I'm not sure if it's a good idea, TK can potentially add a custom flags to its default IREE pipeline and bypassing it means we are testing non-user facing version of the product. |
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Ok that is fine. But, do you have an idea how we can make it clearly visible what flags are being used. Maybe in a comment or through logs. For this PR, this is ok though |
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
create_vmfb_file
option to get vmfb file directlyout_type
!=accumulator_type
exec_args
as code generated by TK expected out param to be present