Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TKW gemm tests #36

Merged
merged 13 commits into from
Dec 18, 2024
Merged

Fix TKW gemm tests #36

merged 13 commits into from
Dec 18, 2024

Conversation

Hardcode84
Copy link
Contributor

@Hardcode84 Hardcode84 commented Dec 13, 2024

  • Use TKW create_vmfb_file option to get vmfb file directly
  • Get scheduling params from the TK itself
  • Disable scheduling for large K as compilation taking too long
  • Support case when out_type != accumulator_type
  • Update exec_args as code generated by TK expected out param to be present
  • Gracefully handle TK errors instead of terminating entire script

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@saienduri
Copy link
Contributor

saienduri commented Dec 13, 2024

Thanks for the fixes Ivan! Is it possible to stick with generate TK mlir and then go through the normal compilation flow? It would be great if we can limit branching off from the general flow only when necessary. This allows us to scale and build an overall clean pipeline and helps also on visibility of how we are compiling (flags, commands, etc)

@Hardcode84
Copy link
Contributor Author

Hardcode84 commented Dec 13, 2024

Is it possible to stick with generate TK mlir and then go through the normal compilation flow?

I'm not sure if it's a good idea, TK can potentially add a custom flags to its default IREE pipeline and bypassing it means we are testing non-user facing version of the product.

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@saienduri
Copy link
Contributor

Ok that is fine. But, do you have an idea how we can make it clearly visible what flags are being used. Maybe in a comment or through logs. For this PR, this is ok though

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84 Hardcode84 merged commit c3bdf8e into nod-ai:main Dec 18, 2024
1 check failed
@Hardcode84 Hardcode84 deleted the fix-gemm branch December 18, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants