Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor aievec and xllvm #546

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Conversation

makslevental
Copy link
Collaborator

@makslevental makslevental commented Jul 13, 2024

This PR vendors AIEVec and XLLVM (including ops/types/attrs etc.). Importantly, we only vendor the components related to translation to llvm ir (no codegen/optimization/etc). The reason for this is the goal of this sprint is to support chess via the llvm ir path i.e., we will add support for chess aie2 intrinsics here instead of mlir-aie.

Note we greatly reduce the number of supported aievec ops down to matmul, shuffle, srs, ups, cast.

@makslevental makslevental force-pushed the makslevental/remove-aie/vendor-aievec branch 7 times, most recently from 622c3ff to 2f7c8d8 Compare July 14, 2024 02:40
@makslevental makslevental force-pushed the makslevental/remove-aie/vendor-aievec branch from 2f7c8d8 to d421d6a Compare July 14, 2024 02:48
@makslevental makslevental changed the title [wip] vendor aievec Vendor aievec and xllvm Jul 14, 2024
@makslevental makslevental marked this pull request as ready for review July 14, 2024 03:14
Copy link
Collaborator

@jtuyls jtuyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As this is a vendor PR, I think we don't need to review this in detail and can do that if/when refactoring in the future. (Like we have done for other vendor PRs)

@makslevental makslevental force-pushed the makslevental/remove-aie/vendor-aievec branch from d421d6a to 3214e43 Compare July 15, 2024 14:38
@makslevental makslevental enabled auto-merge (squash) July 15, 2024 14:44
@makslevental makslevental merged commit 8252b3f into main Jul 15, 2024
2 checks passed
@makslevental makslevental deleted the makslevental/remove-aie/vendor-aievec branch July 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants