Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor AIE/AIEX passes (5/n) #423

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

makslevental
Copy link
Collaborator

@makslevental makslevental commented Jun 16, 2024

This PR is part of a stack of PRs that refactor the dependency on MLIR-AIE. See #430 for more information.

This PR vendors all of the AIE/AIEX passes under our own namespace mlir::iree_compiler::AMDAIE.

Notes:

  1. We still depend (until subsequent PRs) on #include "aie/Dialect/AIE/IR/AIEDialect.h" and #include "aie/Dialect/AIEX/IR/AIEXDialect.h" for AIE/AIEX ops (this PR specifically removes all Transforms/AIEPassses.h etc);
  2. It's not worth bikeshedding/auditing this code yet - subsequent PRs refactor many things dramatically (e.g., removing AIEXToStandard and AIEToStandard passes and joining AIEDmaToNpu with AIETargetNPU). This was the point of merging the mlir-aie lit/unit tests early :)

@nirvedhmeshram @newling this is now ready for review.

@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor branch from bb9298b to 6f22fbb Compare June 16, 2024 20:28
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from f17ccf4 to 1ee828c Compare June 16, 2024 20:28
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor branch from 6f22fbb to 36099e2 Compare June 16, 2024 20:37
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from 1ee828c to fcf42bf Compare June 16, 2024 20:37
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor branch from 36099e2 to 5a6fd9c Compare June 16, 2024 21:02
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from fcf42bf to 604611c Compare June 16, 2024 21:06
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor branch from 5a6fd9c to adf3569 Compare June 16, 2024 21:23
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from 604611c to a1ecc9c Compare June 16, 2024 21:23
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor branch from adf3569 to ec6866b Compare June 16, 2024 21:37
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from a1ecc9c to dd1b554 Compare June 16, 2024 21:39
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor branch from ec6866b to 2d2c2c7 Compare June 16, 2024 21:48
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from dd1b554 to 7e056f6 Compare June 16, 2024 21:49
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor branch 6 times, most recently from 0a9a165 to 3bda5bc Compare June 16, 2024 22:54
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch 2 times, most recently from 046dfeb to 551b68e Compare June 16, 2024 23:01
@makslevental makslevental linked an issue Jun 17, 2024 that may be closed by this pull request
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor branch from 3bda5bc to 8084e2a Compare June 18, 2024 04:51
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from 551b68e to f898b3a Compare June 18, 2024 04:51
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor branch from 8084e2a to 6e30536 Compare June 18, 2024 10:46
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from f898b3a to 62f4f37 Compare June 18, 2024 10:46
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor branch from 6e30536 to f81eba0 Compare June 19, 2024 20:51
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch 2 times, most recently from b2ce977 to ddcfa6a Compare June 22, 2024 19:09
@makslevental makslevental changed the base branch from makslevental/remove-mlir-aie/vendor to makslevental/remove-mlir-aie/direct_target June 22, 2024 19:10
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch 11 times, most recently from e4fccfa to 9cad665 Compare June 24, 2024 17:00
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/direct_target branch 2 times, most recently from 52d7a11 to d4a34e1 Compare June 24, 2024 21:37
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from 9cad665 to 6c3349c Compare June 24, 2024 21:38
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/direct_target branch from d4a34e1 to 3f3cd29 Compare June 24, 2024 21:39
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from 6c3349c to 4f13b0a Compare June 24, 2024 21:39
Base automatically changed from makslevental/remove-mlir-aie/direct_target to main June 24, 2024 22:15
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from 4f13b0a to 466a33a Compare June 24, 2024 22:39
incorporate Switch to using transaction binary flow with no control packet (#1517)

vendor all passes
@makslevental makslevental force-pushed the makslevental/remove-mlir-aie/vendor_passes branch from 466a33a to e201771 Compare June 24, 2024 22:39
@makslevental makslevental merged commit 8b5f4bf into main Jun 24, 2024
2 checks passed
@makslevental makslevental deleted the makslevental/remove-mlir-aie/vendor_passes branch June 24, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracking] Refactor MLIR-AIE dependency
2 participants