[e2e CI][DO NOT REVIEW] Refactor e2e CI tests to make addition of new tests easier #1089
+276
−246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhishek-Varma
changed the title
-- Currently there are lot of repeated codes which makes :- 1. Maintaining the codebase 2. Addition of new tests quite cumbersome. -- Since most tests are bound to go through a certain lowering pipeline, decide whether or not to use ukernel, chess, have additional compilation flags - it's better to separate those as RunningParams instances. -- This way they're handled unanimously at the base class instead of each subclass. -- This can further be refined but for now going ahead with the current design. Signed-off-by: Abhishek Varma <abhvarma@amd.com>
Abhishek-Varma
force-pushed
the
avarma_refactor_e2e_tests
branch
from
fd3a26b to
e856f45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Currently there are lot of repeated codes which makes :-
quite cumbersome.
-- Since most tests are bound to go through a certain lowering pipeline,
decide whether or not to use ukernel, chess, have additional compilation
flags - it's better to separate those as RunningParams instances.
-- This way they're handled unanimously at the base class instead of each
subclass taking the same onus.
-- This can further be refined but for now going ahead with the current
design.
Signed-off-by: Abhishek Varma abhvarma@amd.com