[CI] Merge Matmul class with its Benchmark class #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yu-Zhewen
reviewed
Feb 6, 2025
build_tools/ci/cpu_comparison/run.py
Outdated
| @@ -2183,13 +2052,13 @@ def __init__(self): | |||
|
|
|||
| if (transpose_a, transpose_b) == (False, False): | |||
| NumericTestClass = Matmul | |||
There was a problem hiding this comment.
Maybe just use TestClass here, as NumericTestClass and BenchmarkTestClass are now pointing to the same thing.
yzhang93
force-pushed
the
refactor_performance_test
branch
from
a881253 to
ce178f0
Compare
Yu-Zhewen
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are Matmul/MatmulTranspseB/MatmulTransposeA classes and their Benchmark classes separately. A lot of codes are duplicated between them. This also brings extra efforts and more codes if we introduce other classes, e.g., mmt4d.
This PR removes the Benchmark classes while adding an argument "run_benchmark" to the existing Matmul/MatmulTranspseB/MatmulTransposeA classes.