[Router] Move shim mux port mapping into DeviceModel
#1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuyls
reviewed
Feb 6, 2025
| // 2) shimDMA 1 --> North 7 | ||
| // From BLI to shimDMA: 1) North 2 --> shimDMA 0 | ||
| // 2) North 3 --> shimDMA 1 | ||
| // Add special shim mux connections between DMA/NOC streams and BLI. |
There was a problem hiding this comment.
I know it was introduced earlier, but what's BLI?
There was a problem hiding this comment.
That doesn't seem relevant to us. Should I remove it?
According to the architecture spec: "The BLI block (Boundary Logic Interface) connects COE blocks at the boundary to the FPGA fabric."
There was a problem hiding this comment.
Yeah, I don't think that's relevant to us.
There was a problem hiding this comment.
Maybe good to remove indeed to avoid confusion.
Comment on lines
425
to
447
| /// Maps an MM2S (shim DMA or NOC) port to its corresponding special shim mux | ||
| /// port. | ||
| llvm::SmallDenseMap<std::pair<StrmSwPortType, uint8_t>, | ||
| std::pair<StrmSwPortType, uint8_t>> | ||
| mm2sDmaNocToSpecialShimPortMap = { | ||
| {{StrmSwPortType::DMA, 0}, {StrmSwPortType::NORTH, 3}}, | ||
| {{StrmSwPortType::DMA, 1}, {StrmSwPortType::NORTH, 7}}, | ||
| {{StrmSwPortType::NOC, 0}, {StrmSwPortType::NORTH, 2}}, | ||
| {{StrmSwPortType::NOC, 1}, {StrmSwPortType::NORTH, 3}}, | ||
| {{StrmSwPortType::NOC, 2}, {StrmSwPortType::NORTH, 6}}, | ||
| {{StrmSwPortType::NOC, 3}, {StrmSwPortType::NORTH, 7}}}; | ||
|
|
||
| /// Maps an S2MM (shim DMA or NOC) port to its corresponding special shim mux | ||
| /// port. | ||
| llvm::SmallDenseMap<std::pair<StrmSwPortType, uint8_t>, | ||
| std::pair<StrmSwPortType, uint8_t>> | ||
| s2mmDmaNocToSpecialShimPortMap = { | ||
| {{StrmSwPortType::DMA, 0}, {StrmSwPortType::NORTH, 2}}, | ||
| {{StrmSwPortType::DMA, 1}, {StrmSwPortType::NORTH, 3}}, | ||
| {{StrmSwPortType::NOC, 0}, {StrmSwPortType::NORTH, 2}}, | ||
| {{StrmSwPortType::NOC, 1}, {StrmSwPortType::NORTH, 3}}, | ||
| {{StrmSwPortType::NOC, 2}, {StrmSwPortType::NORTH, 4}}, | ||
| {{StrmSwPortType::NOC, 3}, {StrmSwPortType::NORTH, 5}}}; |
There was a problem hiding this comment.
These could be static const
| {{StrmSwPortType::NOC, 2}, {StrmSwPortType::NORTH, 4}}, | ||
| {{StrmSwPortType::NOC, 3}, {StrmSwPortType::NORTH, 5}}}; | ||
|
|
||
| /// Retrieves the speicail shim mux port that connects a given MM2S or S2MM |
There was a problem hiding this comment.
Suggested change
| /// Retrieves the speicail shim mux port that connects a given MM2S or S2MM | |
| /// Retrieves the special shim mux port that connects a given MM2S or S2MM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.