[Dma] Don't check Dma unit dims during subsumption and fold them during controlCodeLowering #1070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, we need to check the number of sizes/strides before dma loop subsumption to make sure the number of dims are not exceed the maximum after subsumption. However, this blocks some opportunities for loop subsumption when there are unit dimensions which are not canonicalized because the offsets of these dimensions are none 0. For example the following loop cannot be subsumed because there are already 4 dimensions on L3 source side.
This PR relaxes the constraint by only checking the non-unit dimensions, so the above loop can be subsumed into dma as
And this dma can be further canonicalized.