[CtrlPkt] Add a pass to split control packet payload into chunks of 4 #1052
Conversation
Yu-Zhewen
requested review from
makslevental,
nirvedhmeshram,
newling,
MaheshRavishankar,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
Yu-Zhewen
changed the title
Yu-Zhewen
changed the title
|
|
||
| // ----- | ||
|
|
||
| // For control packet reads (where `opcode=1` and `data` are not present), the split still occurs, with only the `address` and `length` attributes being updated. |
There was a problem hiding this comment.
What's the rationale here? Shouldn't we throw an error?
There was a problem hiding this comment.
We can send a control packet to request the core to send data back. In this case, the opcode is set to 1 (indicating a read request), the length field specifies the number of words to be returned, and the data attribute is left empty, as only the header is sent to the core.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok, thanks for the explanation, makes sense!
Also, just thinking about this now, but I think using an enum attribute instead of an int for the opcode would be helpful: CtrlPktType::Read instead of 1 etc (not for this PR).
There was a problem hiding this comment.
Thanks, I will make a separate PR for that.
There was a problem hiding this comment.
implemented in #1056
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIESplitControlPacketData.cpp
Outdated
Show resolved
Hide resolved
No description provided.