Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump IREE to f27feffa3d44c834a184ed3ea4b704316fd1769e #1001

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Bump IREE to f27feffa3d44c834a184ed3ea4b704316fd1769e #1001

merged 4 commits into from
Jan 2, 2025

Conversation

yzhang93
Copy link
Contributor

No description provided.

@yzhang93 yzhang93 changed the title Bump IREE to a43d893b4d1946fabd7a6c7eb74c63ba7d42cdd5 Bump IREE to f27feffa3d44c834a184ed3ea4b704316fd1769e Dec 31, 2024
@yzhang93 yzhang93 requested a review from newling as a code owner December 31, 2024 22:25
@yzhang93
Copy link
Contributor Author

yzhang93 commented Jan 1, 2025

@makslevental The macOS failed because upstream started to use nanobind 2.4.0. Any idea how to solve the below error?

ld: Undefined symbols:
  _PyClassMethod_New, referenced from:
      populateDialectLLVMSubmodule(nanobind::module_ const&) in DialectLLVM.cpp.o
      populateDialectLLVMSubmodule(nanobind::module_ const&) in DialectLLVM.cpp.o
      populateDialectLLVMSubmodule(nanobind::module_ const&) in DialectLLVM.cpp.o
      populateDialectLLVMSubmodule(nanobind::module_ const&) in DialectLLVM.cpp.o
      populateDialectLLVMSubmodule(nanobind::module_ const&) in DialectLLVM.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@yzhang93
Copy link
Contributor Author

yzhang93 commented Jan 2, 2025 •
edited
Loading

As discussed with @makslevental offline, to unblock this bump, I'm disabling macos workflow until there's a fix for the nanobind error. CC @jtuyls @newling @Abhishek-Varma @Yu-Zhewen

makslevental
makslevental approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are upstream shenanigans afoot so I will keep track and re-enable macos if/when those get resolved.

@yzhang93 yzhang93 merged commit d9b65af into main Jan 2, 2025
7 of 8 checks passed
@yzhang93 yzhang93 deleted the bump_iree_12302024 branch January 2, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makslevental makslevental makslevental approved these changes

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@nirvedhmeshram nirvedhmeshram Awaiting requested review from nirvedhmeshram nirvedhmeshram is a code owner

@Abhishek-Varma Abhishek-Varma Awaiting requested review from Abhishek-Varma Abhishek-Varma is a code owner

@jtuyls jtuyls Awaiting requested review from jtuyls jtuyls is a code owner

@newling newling Awaiting requested review from newling newling is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzhang93 @makslevental