Scripts for Hipifying DGL in place #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the result of iterative work on the hipified files, so we're prefetching some replacements I didn't discover until later. The source files also need some modification to make this all work.
|
@jeffdaily PTAL |
|
So far so good. |
This was referenced Jan 16, 2025
Merged
GMNGeoffrey
added a commit
that referenced
this pull request
Jan 29, 2025
This is just the output of the hipify-inplace.sh and hipify-tensoradapter.py scripts with no further modifications, so probably you'll want to just spot-check. I think it will be easier to review changes to the actual HIP source directly rather than trying to thing about what the hipify script will do and since there are a decent number of changes to get the build and tests working, that seems worth it. In the end we should have a bunch of hip source files and .prehip cuda files that they can be generated from. Then we can handle organization however we want: restore the originals and have hipification be part of a build process, have the hip versions on a separate branch, etc. I put the .prehip files in a separate commit to keep things a bit cleaner. Note that this PR is based off of #1. I didn't make that the base branch though because then it would all be in my fork.
GMNGeoffrey
added a commit
that referenced
this pull request
Jan 29, 2025
These changes are on the original DGL source code. These plus running `script/hipify-inplace.sh` yields the hipified version of DGL which is identical to the code currently in #9. The version in this commit should still run with CUDA. This obviously shouldn't be merged into the same branch as PRs #1 through #9. The idea is that this would be the PR we would need for upstream (although I'm guessing they would actually want it in smaller chunks).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the result of iterative work on the hipified files, so we're
prefetching some replacements I didn't discover until later. The source
files also need some modification to make this all work.
Also some .gitignore additions mostly for VSCode and CMake.
Note: I think we should probably not merge this into the master branch
and rather keep that a pristine copy of upstream with a separate branch
for the hipify stuff.