Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize the compiler build/packaging to more closely match ROCM>= 6.4. #66

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

stellaraccident
Copy link
Contributor

@stellaraccident stellaraccident commented Feb 6, 2025

  • Builds device-libs as part of amd-llvm, installing into lib/llvm.
  • Breaks amd-comgr and hipcc out to standalone builds that install into the root.
  • Removes hipcc from the path and adds clr/bin to the PATH, ensuring that clr/dist/bin/hipconfig always has access to its resources needed to identify version, compiler, etc.
  • Adds compatibility flags to device-libs to put them in the clang resource dir and the old location.
  • For the "amd-hip" toolchain, gets all binaries from clr.
  • Removes the need for manual flag pasting to specify bitcode directories.
  • There is still a bit of path wonkiness between llvm and clr, but it should be fine until it can be cleaned up more.

Works around #67

…6.4.

* Builds device-libs as part of amd-llvm, installing into lib/llvm.
* Breaks amd-comgr and hipcc out to standalone builds that install into the root.
* Removes hipcc from the path and adds clr/bin to the PATH, ensuring that clr/dist/bin/hipconfig always has access to its resources needed to identify version, compiler, etc.
* Adds compatibility flags to device-libs to put them in the clang resource dir and the old location.
* For the "amd-hip" toolchain, gets all binaries from clr.
* Removes the need for manual flag pasting to specify bitcode directories.
@stellaraccident stellaraccident merged commit 3a6784b into main Feb 6, 2025
1 check passed
@stellaraccident stellaraccident deleted the compiler_package_layout branch February 6, 2025 02:37
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants