[Fix rubocop#707] Fix an error when a variable is passed to has_many …

…or has_one with double splat

changelog/fix_an_error_when_a_variable_is_passed.md

@@ -0,0 +1 @@
+* [#707](https://github.com/rubocop/rubocop-rails/issues/707): Fix an error when a variable is passed to has_many or has_one with double splat. ([@nobuyo][])

lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb

@@ -116,7 +116,9 @@ def contain_valid_options_in_with_options_block?(node)
         def valid_options?(options)
           return false if options.nil?
 
-          options = options.first.children.first.pairs if options.first.kwsplat_type?
+          if options.first.kwsplat_type? && options.first.children.first.hash_type?
+            options = options.first.children.first.pairs
+          end
 
           return true unless options
           return true if options.any? do |o|

spec/rubocop/cop/rails/has_many_or_has_one_dependent_spec.rb

@@ -36,6 +36,15 @@ class Person < ApplicationRecord
       RUBY
     end
 
+    it 'registers an offense when a variable passed with double splat' do
+      expect_offense(<<~RUBY)
+        class Person < ApplicationRecord
+          has_one :foo, **bar
+          ^^^^^^^ Specify a `:dependent` option.
+        end
+      RUBY
+    end
+
     it 'does not register an offense when specifying default `dependent: nil` strategy' do
       expect_no_offenses(<<~RUBY)
         class Person < ApplicationRecord