Run the linting action on pull requests #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Event is only opened, reopened, and synchronize by default
|
Would it be more appropriate to create a new action which runs lint on PRs only? |
|
We could, it doesn't matter terribly since nothing would ever be published on a pr. The other thing we could do is just exclude the publishing action from pull requests using an if conditional, thereby only having lint run (which I would prefer here as to avoid having duplicate actions) |
Neztore
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint check currently does not run on pull requests (until merged), it would be easier than having to remember to check manually each time.
auto should not be affected as it only publishes with a release label