Update updateDeveloperProduct function to new 'apis.' endpoint; removes iconImageAssetId parameter (needs new method call) #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ves iconImageAssetId parameter (needs new method call)
|
Is this similar to #751 ? Edit: As in could the same fix be applied to both. Not that it's a duplicate. |
Neztore
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint currently referenced by
updateDeveloperProductis deprecated and responds with a HTTP 404; this change updates the method to match what is used by the website.This introduces a breaking change since
iconImageAssetIdis no longer supported. I recommend we create a new method for updating the icon rather than nesting the request inside this method; especially since the website is now required a full FormData upload instead of creating a decal and referencing it'sassetId.