Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getGameRevenue #600

Merged
merged 11 commits into from
Apr 23, 2023
Merged

Added getGameRevenue #600

merged 11 commits into from
Apr 23, 2023

Conversation

GoldenJayz
Copy link
Contributor

This just gets the game revenue. This was not in noblox.js before so I added it in.

@suufi
Copy link
Member

suufi commented Jul 23, 2022

I can't approve this because it's missing return type and typings. See other functions for examples.

@Neztore
Copy link
Member

Neztore commented Nov 2, 2022

Could you lint this so it passes the CI?

Copy link
Member

@Neztore Neztore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above: Please pass CI

Copy link
Contributor Author

@GoldenJayz GoldenJayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just linted this. Ty :)

Copy link
Member

@Neztore Neztore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add typings to index.d.ts and jsdocs as required. Thanks for linting!

Copy link
Contributor Author

@GoldenJayz GoldenJayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added typings

@GoldenJayz
Copy link
Contributor Author

@Neztore

Copy link
Contributor Author

@GoldenJayz GoldenJayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neztore
Copy link
Member

Neztore commented Apr 23, 2023

Hm. Odd. Never got any emails for this one. I'll review now

@Neztore Neztore merged commit fa2cefd into noblox:master Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants