Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling to event docs #583

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Add error handling to event docs #583

merged 2 commits into from
Jun 24, 2022

Conversation

Neztore
Copy link
Member

@Neztore Neztore commented Jun 10, 2022

Fixes #527

It's better practice to handle the errors, and it was throwing a lot of people off as the errors could crash applications if not handled correctly - sort of like an unhandled rejection.

@Neztore Neztore added the documentation Changes only affect the documentation label Jun 10, 2022
@Neztore Neztore requested a review from alanbixby June 10, 2022 14:36
@Neztore
Copy link
Member Author

Neztore commented Jun 10, 2022

either alan or suufi review when you get a chance please

@suufi suufi self-requested a review June 19, 2022 17:11
@suufi suufi enabled auto-merge (squash) June 24, 2022 07:55
@suufi suufi merged commit e2a07a7 into master Jun 24, 2022
@Neztore Neztore deleted the event-docs-fix branch May 18, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change event examples to add error handling
2 participants