Refactored getCurrentUser.js and setCookie #579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neztore
changed the title
Neztore
requested changes
Jun 10, 2022
| }) | ||
| } | ||
| try { | ||
| const res = await getCurrentUser({ jar: { session: args.cookie } }) |
There was a problem hiding this comment.
Could return await getCurrentUser(...); to remove an unnecessary line and variable.
There was a problem hiding this comment.
Or, a better solution would be to match the original behaviour and actually set the session token following validation!
Please test your PRs. Reading your code, if validate is enabled the internally stored cookie will never be updated.
Chosey98
approved these changes
Jul 4, 2022
Merged
|
No activity and fixed elsewhere |
Neztore
added a commit
that referenced
this pull request
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the export function easier to read