Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define onAuditLog delay (10s) and defaultDelay #355

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

alanbixby
Copy link
Member

Currently onAuditLog() references a delay that does not exist, therefore the delay defaults to undefined -> 0.

This causes many individuals to have 429: TooManyRequest errors; theoretically this should alleviate things for a fair number of people.

I've also added defaultDelay to settings.json as a fallback in-case any future event listeners accidentally make this mistake.

Copy link
Member

@Neztore Neztore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The combined use of a ternary and OR are perhaps and difficult to read, but I think this is mergable regardless.

@Neztore Neztore merged commit 179836b into noblox:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants