Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typings issue #309

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Fixed typings issue #309

merged 1 commit into from
Mar 29, 2021

Conversation

LightYagami200
Copy link
Contributor

Replaced ThumbnailSizes to HeadshotSizes for method getPlayerThumbnail

Fixed typings issue
3d275a5 
Replaced `ThumbnailSizes` to `HeadshotSizes` for method `getPlayerThumbnail`
@alanbixby
Copy link
Member

Context:
https://github.com/suufi/noblox.js/blob/3d275a5ca2584815d41d5b33c6bd30bb119956e6/typings/index.d.ts#L771-L774

https://github.com/suufi/noblox.js/blob/59449074a542b54776d854c1faa943569365c51f/typings/index.d.ts#L1555

alanbixby
alanbixby approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@alanbixby alanbixby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; thank you for spotting the type error.

@Neztore Neztore merged commit 2bb07f1 into noblox:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanbixby alanbixby alanbixby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LightYagami200 @alanbixby @Neztore