Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change TimestepForcingJSON's modeled_timestep to be interval #118

Merged
2 commits merged into from
Aug 11, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2021

fixes #117

@ghost ghost added the bug Bug when generating configuration label Aug 11, 2021
@ghost ghost self-assigned this Aug 11, 2021
@ghost ghost merged commit 35226d6 into main Aug 11, 2021
@ghost ghost deleted the fix/forcing_interval branch August 11, 2021 15:55
@saeed-moghimi-noaa
Copy link

@zacharyburnettNOAA

I suggest to use a more descriptive variable name like:

ForcingTimeStep or ForcingInterval

@ghost
Copy link
Author

ghost commented Aug 23, 2021

@zacharyburnettNOAA

I suggest to use a more descriptive variable name like:

ForcingTimeStep or ForcingInterval

I thought about that, but it is already in a ForcingJSON object, or in a configure_atmesh.json or configure_ww3data.json file, so I figure it would be redundant as you know which file you are looking in. The full name in code is ForcingJSON['interval']

I was thinking of making it read_interval because that is the interval at which it is read by the model, in modeled time

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug when generating configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change modeled_timestep to be forcing_interval
2 participants