Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to dependency installation in setup #113

Merged
13 commits merged into from
Aug 2, 2021
Merged

improvements to dependency installation in setup #113

13 commits merged into from
Aug 2, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 2, 2021

No description provided.

@ghost ghost added the enhancement New feature or request label Aug 2, 2021
@ghost ghost self-assigned this Aug 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #113 (fda4df5) into main (1f23f21) will increase coverage by 0.32%.
The diff coverage is 71.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   74.32%   74.65%   +0.32%     
==========================================
  Files          18       18              
  Lines        1819     1874      +55     
==========================================
+ Hits         1352     1399      +47     
- Misses        467      475       +8     
Flag Coverage Δ
python3.9-Linux 74.65% <71.18%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
coupledmodeldriver/client/initialize_adcirc.py 0.00% <0.00%> (ø)
coupledmodeldriver/generate/adcirc/__init__.py 100.00% <ø> (ø)
coupledmodeldriver/platforms.py 100.00% <ø> (ø)
coupledmodeldriver/utilities.py 76.19% <0.00%> (ø)
coupledmodeldriver/configure/forcings/base.py 88.67% <33.33%> (+8.77%) ⬆️
coupledmodeldriver/generate/adcirc/base.py 86.33% <75.00%> (+0.53%) ⬆️
coupledmodeldriver/generate/adcirc/script.py 81.13% <77.63%> (+7.05%) ⬆️
coupledmodeldriver/configure/base.py 82.73% <82.75%> (+0.91%) ⬆️
coupledmodeldriver/generate/adcirc/generate.py 83.72% <88.97%> (-2.00%) ⬇️
coupledmodeldriver/configure/configure.py 85.32% <100.00%> (+2.13%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0d9de...fda4df5. Read the comment docs.

@ghost ghost merged commit eeee2d4 into main Aug 2, 2021
@ghost ghost deleted the feature/setup branch August 2, 2021 18:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants