Hysplitdev #28
Merged
Hysplitdev #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created reader for PAMS data
was initialized inside the time loop and when last time periods contained no data, it was then empty. This caused problems for the add_species function.
Merge branch 'hysplitdev' of https://github.com/noaa-oar-arl/monetio into hysplitdev
Development
|
Hello @amcz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-02-09 15:16:57 UTC |
|
@amcz is this ready to go? has it been tested? |
|
@aring1988 does the PAMS data really read in as a xarrray.DataArray or is it a pandas.Dataframe? |
|
Yes. Thanks!
Alice
…On Thu, Feb 4, 2021 at 10:34 AM Barry Baker ***@***.***> wrote:
@amcz <https://github.com/amcz> is this ready to go? has it been tested?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEWG2HWCY5WPXPUAO5A7XSLS5K5ANANCNFSM4XC5NYTQ>
.
--
Dr. Alice Crawford
NOAA / Air Resources Laboratory/
Atmospheric Sciences Modeling Division.
R/ARL/ASMD - NCWCP - Room 4212
5830 University Research Court
College Park, Maryland 20740
http://www.ready.noaa.gov/HYSPLIT.php
Phone: Direct Number:+1-301-683-13 <%2B1-301-683-1379>80
|
|
I'd like to hear from @aring1988 on the PAMS reader before the merge. Need to keep this consistent between modules. |
|
It opens as a pandas.dataframe and writes the json file into a csv for
readability. The json files are really cumbersome to use so I thought this
would be easier. If you dont think this is useful, just go ahead and remove
it.
Allison M. Ring, PhD
NOAA Air Resources Laboratory
OAR/ARL - NCWCP - Room 4212
5830 University Research Court
College Park, MD 20740
allison.ring@noaa.gov
Direct line: (301) 683-1383
Post-Doctoral Associate
Cooperative Institute for Satellite Earth System Studies (CISESS)
University of Maryland
College Park, MD
…On Thu, Feb 4, 2021 at 10:36 AM Barry Baker ***@***.***> wrote:
@aring1988 <https://github.com/aring1988> does the PAMS data really read
in as a xarrray.DataArray or is it a pandas.Dataframe?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALMRZOQOF4XWYUOM7ADB433S5K5JHANCNFSM4XC5NYTQ>
.
|
|
@aring1988 Ok. Can we rename open_dataset to add_data to be inline with the other point observations? |
|
Sure thing, I will make that change and do another push.
Best,
Allison M. Ring, PhD
NOAA Air Resources Laboratory
OAR/ARL - NCWCP - Room 4212
5830 University Research Court
College Park, MD 20740
allison.ring@noaa.gov
Direct line: (301) 683-1383
Post-Doctoral Associate
Cooperative Institute for Satellite Earth System Studies (CISESS)
University of Maryland
College Park, MD
…On Mon, Feb 8, 2021 at 11:31 AM Barry Baker ***@***.***> wrote:
@aring1988 <https://github.com/aring1988> Ok.
Can we rename open_dataset to add_data to be inline with the other point
observations?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALMRZOQRN4QIURLZPQ5RW6LS6AGW7ANCNFSM4XC5NYTQ>
.
|
|
Hi Barry,
I changed it to add_data and fixed some other issues (cleaned up the code
and removed unnecessary functions). I pushed it to the master branch on my
forked monetio repo, is this right? I forget the process, I am just not
doing it often enough. Here is the jupyter notebook file as well - it is
updated to work with the new adjustments to the code.
Please let me know if you have any questions or if I need to do something
else.
Thanks!
Allison M. Ring, PhD
NOAA Air Resources Laboratory
OAR/ARL - NCWCP - Room 4212
5830 University Research Court
College Park, MD 20740
allison.ring@noaa.gov
Direct line: (301) 683-1383
Post-Doctoral Associate
Cooperative Institute for Satellite Earth System Studies (CISESS)
University of Maryland
College Park, MD
…On Mon, Feb 8, 2021 at 11:31 AM Barry Baker ***@***.***> wrote:
@aring1988 <https://github.com/aring1988> Ok.
Can we rename open_dataset to add_data to be inline with the other point
observations?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALMRZOQRN4QIURLZPQ5RW6LS6AGW7ANCNFSM4XC5NYTQ>
.
|
|
@amcz and @aring1988 I think that this needs to be pushed to the hypslitdev branch to be included in this pull request |
|
I'm not sure that Allison can do that as she isn't a contributor to monetio.
Allison if you send me the code, I can add it to the hysplitdev branch.
Although this isn't really related to hysplit.
Cheers,
Alice
…On Tue, Feb 9, 2021 at 9:21 AM Barry Baker ***@***.***> wrote:
@amcz <https://github.com/amcz> and @aring1988
<https://github.com/aring1988>
I think that this needs to be pushed to the hypslitdev branch to be
included in this pull request
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEWG2HRYISUFE4ZGHZNSYWTS6FAHNANCNFSM4XC5NYTQ>
.
--
Dr. Alice Crawford
NOAA / Air Resources Laboratory/
Atmospheric Sciences Modeling Division.
R/ARL/ASMD - NCWCP - Room 4212
5830 University Research Court
College Park, Maryland 20740
http://www.ready.noaa.gov/HYSPLIT.php
Phone: Direct Number:+1-301-683-13 <%2B1-301-683-1379>80
|
Made necessary adjustments and removed unnecessary function
|
perfect! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #26. Bug when creating the species id attribute in the hysplit xarray dataset.