Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISH for empty sites #109

Merged
merged 11 commits into from
May 9, 2023
Merged

Fix ISH for empty sites #109

merged 11 commits into from
May 9, 2023

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Apr 20, 2023

Discovered some bugs related to empty sites while setting up ISH support for MM.

  • for partially empty (i.e. one or more but not all sites missing all data for that period), bytes conversion to string would fail, now the method just returns the input df if empty
  • for fully empty, the resample groupby would fail, now skipped if empty

@zmoon zmoon added the bug Something isn't working label Apr 20, 2023
zmoon added 4 commits April 20, 2023 09:21
@zmoon zmoon mentioned this pull request May 8, 2023
@zmoon
Copy link
Member Author

zmoon commented May 8, 2023

Note EPA AQS link check was briefly failing is failing intermittently

( index: line 73) broken https://www.epa.gov/aqs/ - HTTPSConnectionPool(host='origin-awswest-www.epa.gov', port=443): Max retries exceeded with url: /aqs (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f04b087e880>: Failed to establish a new connection: [Errno 110] Connection timed out'))

usually it succeeds if I just run it a second time though, weird

@zmoon zmoon marked this pull request as ready for review May 8, 2023 22:19
@zmoon zmoon requested a review from bbakernoaa May 8, 2023 22:34
@zmoon zmoon merged commit 3927588 into noaa-oar-arl:develop May 9, 2023
@zmoon zmoon deleted the fix/ish branch May 9, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants