Hysplitdev #108
Merged
Hysplitdev #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_latlongrid function. get_latlongrid function now calls getlatlon. added gridhash attribute to class to replace attributes such as llcrnr_lon that described the grid. replaced np.arange with np.linspace when step size is not an integer (in getlatlon function).
xarray DataArray input which does not have latitude, longitude coordinates
get_latlongrid improved exception statements get_latlon replace x>=180 test with x>=180+lon_tolerance get_thickness modified to calculate if attribute specifying vertical levels is bad. hytraj.py added documentation to combine_dataset updated combine_dataset for better logic when renumber=False and taglist=None. added unit testing test_hysplit.py and test_hytraj.py in the tests directory. test_hytraj.py utilizes tdump.1 and tdump.2 files in the data directory.
accepted all changes from HEAD.
|
@amcz the tests did not all pass. Generally we want everything to be passing before merging. Also I would have been happy to review a bit. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge hysplitdev back into develop.
Addresses issues #102 adding function to hytraj to combine several tdump files into one dataframe.
Addresses issue #103 add some unit testing for hysplit.py and hytraj.py
Small changes to hysplit.py functions
get_latlongrid improved exception statements
get_latlon replace x>=180 test with x>=180+lon_tolerance
get_thickness modified to calculate if attribute specifying vertical
levels is bad.