Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct return values when missing resolver #87

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

steve-tucker
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.82%. Comparing base (566dd35) to head (13dc396).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
resolver.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   59.28%   59.82%   +0.53%     
==========================================
  Files          54       54              
  Lines        4883     4946      +63     
  Branches     1116     1154      +38     
==========================================
+ Hits         2895     2959      +64     
+ Misses       1359     1354       -5     
- Partials      629      633       +4     
Flag Coverage Δ
macos 55.87% <0.00%> (+0.11%) ⬆️
ubuntu 56.27% <0.00%> (+0.97%) ⬆️
ubuntu_curl 58.39% <0.00%> (+1.01%) ⬆️
windows 56.72% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmoinvaz nmoinvaz merged commit cd222bc into master Feb 18, 2025
21 of 22 checks passed
@nmoinvaz nmoinvaz deleted the steve/fix-types branch February 18, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants