Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value of get_ptr for unsigned integers #4525

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

nlohmann
Copy link
Owner

Closes #4475

@coveralls
Copy link

coveralls commented Nov 30, 2024

Coverage Status

coverage: 99.649%. remained the same
when pulling c69d547 on issue-4475
into 1b9a9d1 on develop.

@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Nov 30, 2024
@nlohmann
Copy link
Owner Author

nlohmann commented Dec 5, 2024

Hey @gregmarr, can you please have a look at this?

@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 6, 2024
@nlohmann nlohmann merged commit 9f60e85 into develop Dec 6, 2024
122 checks passed
@nlohmann nlohmann deleted the issue-4475 branch December 6, 2024 17:38
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
* 🐛 fix return value of get_ptr for unsigned integers

* 📝 update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation M review needed It would be great if someone could review the proposed changes. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid union access for get_ref/get_ptr with unsigned integer
3 participants