Fixed init-list construction when size_type is not int #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmarr
reviewed
Sep 7, 2023
tomalakgeretkal
force-pushed
the
custom-int-fix
branch
from
49913a4 to
2b2f392
Compare
|
#4083 has been merged |
tomalakgeretkal
force-pushed
the
custom-int-fix
branch
from
2b2f392 to
23b92db
Compare
|
Amalgamated. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale in code comments. I thought about adding a new unit test but it was a bit beyond me. Feel free to make suggestions!
Note that this has yet to be amalgamated (waiting for #4083).