Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang-tools to required tools for ci_static_analysis_clang #3724

Merged
merged 16 commits into from
Sep 13, 2022
Merged

Add clang-tools to required tools for ci_static_analysis_clang #3724

merged 16 commits into from
Sep 13, 2022

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Sep 6, 2022

Fix build, see #3723 (comment)

@coveralls
Copy link

coveralls commented Sep 6, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 1780203 on fix_pipeline into 307c053 on develop.

@falbrechtskirchinger
Copy link
Contributor

You can cancel my workflows since they're going to fail anyway.

@github-actions github-actions bot added M and removed S labels Sep 6, 2022
@github-actions github-actions bot added the tests label Sep 6, 2022
@github-actions github-actions bot added L and removed M labels Sep 6, 2022
falbrechtskirchinger
falbrechtskirchinger suggested changes Sep 11, 2022
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected more cases where NOLINT might be needed.

I don't understand why variables that curiously always seem to appear in CHECK(var == ...) and can clearly be const are not being complained about.

tests/src/unit-class_const_iterator.cpp
Comment on lines +23 to +24
json const j(json::value_t::null);
json::const_iterator const it(&j);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine but is another one of those corner cases we should pay attention to in this PR.

@falbrechtskirchinger falbrechtskirchinger mentioned this pull request Sep 12, 2022
Merged
falbrechtskirchinger
falbrechtskirchinger approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.3 milestone Sep 13, 2022
@nlohmann nlohmann merged commit 58bd97e into develop Sep 13, 2022
@nlohmann nlohmann deleted the fix_pipeline branch September 13, 2022 10:58
@nlohmann nlohmann mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falbrechtskirchinger falbrechtskirchinger falbrechtskirchinger approved these changes

Assignees
No one assigned
Labels
CI L tests
Projects
None yet
Milestone
Release 3.11.3
Development

Successfully merging this pull request may close these issues.
3 participants
@nlohmann @coveralls @falbrechtskirchinger