-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add file input adapter #1392
Merged
nlohmann
merged 12 commits into
nlohmann:develop
from
mtalliance:feature/addFileInputAdapter
Dec 16, 2018
Merged
Feature/add file input adapter #1392
nlohmann
merged 12 commits into
nlohmann:develop
from
mtalliance:feature/addFileInputAdapter
Dec 16, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. This enable the possibility of using low eand device with this library.
…e. This enable the possibility of using low eand device with this library.
jaredgrubb
suggested changes
Dec 12, 2018
…sing unique_ptr with custom destructor will ensure that
nlohmann
requested changes
Dec 12, 2018
I changed all the fclose, fopen FILE to be std:: |
nlohmann
approved these changes
Dec 16, 2018
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enable using stdio file acces to reduce at minimum the RAM usage. When using this library with arm-none-eabi-gcc, the streams are very heavy in RAM and Flash. This new adapter is not using the streams at all. This fix the issue #1370
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.