feat(component-library-react/paragraph): deprecate lead and small for appearance attribute #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2552 +/- ##
==========================================
+ Coverage 93.63% 93.97% +0.33%
==========================================
Files 152 154 +2
Lines 1257 1311 +54
Branches 264 294 +30
==========================================
+ Hits 1177 1232 +55
+ Misses 77 76 -1
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
@remypar5 Thanks for your PR! |
…improve-paragraph
remypar5
changed the title
matijs
reviewed
Oct 9, 2024
- als je niet de `enum` kan valideren, bijvoorbeeld als die uit een CMS komt, dan is het handig dat `string` ook mag - ik wil niet `appearance="default"` in de code samples hebben, die bestaat niet - handig om migration steps uit te leggen <img width="361" alt="Screenshot 2024-10-13 at 15 22 35" src="https://github.com/user-attachments/assets/01c6b0cc-b6fe-46dc-ba4d-a30c3cb623b3">
remypar5
changed the title
Robbert
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
leadandsmallattributes in favor of the newappearance="lead|small"attribute. They are still supported and don't break any current implementation. When theappearanceattribute is there, it will take priority.Examples
Closes #1800