feat: add utrecht-button-column-gap #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: button missing css in storybook
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Robbert
commented
Jul 29, 2024
bddjong
force-pushed
the
feat/utrecht-button-column-gap
branch
from
8982037
to
999f5fb
Compare
bddjong
force-pushed
the
feat/utrecht-button-column-gap
branch
from
999f5fb
to
004035f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
=======================================
Coverage 97.79% 97.80%
=======================================
Files 148 148
Lines 1136 1137 +1
Branches 222 227 +5
=======================================
+ Hits 1111 1112 +1
Misses 24 24
Partials 1 1 ☔ View full report in Codecov by Sentry. |
bddjong
force-pushed
the
feat/utrecht-button-column-gap
branch
from
004035f
to
55b0177
Compare
bddjong
force-pushed
the
feat/utrecht-button-column-gap
branch
3 times, most recently
from
10a24b1
to
589d899
Compare
Robbert
commented
Aug 26, 2024
packages/web-component-library-stencil/src/components/button.tsx
Outdated
Show resolved
Hide resolved
packages/component-library-react/packages/button-react/src/index.tsx
Outdated
Show resolved
Hide resolved
bddjong
force-pushed
the
feat/utrecht-button-column-gap
branch
from
589d899
to
9bf3f62
Compare
bddjong
force-pushed
the
feat/utrecht-button-column-gap
branch
from
4d1c967
to
9bf3f62
Compare
bddjong
force-pushed
the
feat/utrecht-button-column-gap
branch
from
04fac78
to
b652530
Compare
Robbert
force-pushed
the
feat/utrecht-button-column-gap
branch
from
b652530
to
e661482
Compare
Yolijn
previously approved these changes
Sep 16, 2024
Yolijn
reviewed
Sep 16, 2024
|
Maar is ook al zo in main https://utrecht-git-main-nl-design-system.vercel.app/storybook/?path=/story/react_react-button--primary-action-default dus een los issue om op te lossen |
Robbert
force-pushed
the
feat/utrecht-button-column-gap
branch
from
e661482
to
20e089c
Compare
|
@Yolijn Ik heb alleen nog even gerebased, verder niks veranderd. |
Robbert
force-pushed
the
feat/utrecht-button-column-gap
branch
from
20e089c
to
f4987e2
Compare
Yolijn
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
utrecht-button-column-gapwith__labelelement. Also fixes the button stories missing CSSTodo after feedback
<utrecht-icon-... slot="icon />