refactor: avoid having unexecuted code for non-existing APIs

Causes TypeScript linting errors
nl-design-system · Aug 4, 2024 · 55e6e72 · 55e6e72
1 parent 1e75738
commit 55e6e72
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 23 deletions.
diff --git a/packages/component-library-react/src/FormFieldTextbox.test.tsx b/packages/component-library-react/src/FormFieldTextbox.test.tsx
@@ -636,13 +636,7 @@ describe('Form field with a textbox', () => {
     });
 
     // Test doesn't work, Testing Library doesn't support testing read only state
-    it.skip('is not read-only by default', () => {
-      render(<FormFieldTextbox {...defaultProps} />);
-
-      const textbox = screen.getByRole('textbox');
-
-      expect(textbox).not.toBeReadOnly();
-    });
+    it.skip('is not read-only in the accessibility tree by default', () => {});
 
     it('omits non-essential disabled attributes when not read-only', () => {
       render(<FormFieldTextbox {...defaultProps} readOnly={false} />);
@@ -654,13 +648,7 @@ describe('Form field with a textbox', () => {
     });
 
     // Test doesn't work, Testing Library doesn't support testing read only state
-    it.skip('can have a read-only state', () => {
-      render(<FormFieldTextbox {...defaultProps} disabled />);
-
-      const textbox = screen.getByRole('textbox');
-
-      expect(textbox).toBeReadonly();
-    });
+    it.skip('can have a read-only state in the accessibility tree', () => {});
 
     it('can have a read-only state in CSS', () => {
       const { container } = render(<FormFieldTextbox {...defaultProps} readOnly />);

diff --git a/packages/component-library-react/src/IndexCharNav.test.tsx b/packages/component-library-react/src/IndexCharNav.test.tsx
@@ -62,8 +62,8 @@ describe('Index character navigation', () => {
     }));
 
     render(<IndexCharNav onLinkClick={mockHandleLetterClick} characters={characters} component="button" />);
-    const buttons = screen.getAllByRole('button');
-    fireEvent.click(buttons[0]);
+    const button = screen.getByRole('button', { name: 'A' });
+    fireEvent.click(button);
 
     expect(mockHandleLetterClick).toHaveBeenCalledWith('A');
   });

diff --git a/packages/component-library-react/src/Listbox.test.tsx b/packages/component-library-react/src/Listbox.test.tsx
@@ -55,13 +55,7 @@ describe('Listbox', () => {
 
   describe('read-only state', () => {
     // `isReadOnly()` is not supported, unfortunately
-    it.skip('has a read-only listbox', () => {
-      render(<Listbox disabled />);
-
-      const listbox = screen.getByRole('listbox');
-
-      expect(listbox).isReadOnly();
-    });
+    it.skip('has a listbox that is read-only in the accessibility tree', () => {});
   });
 
   it('supports ForwardRef in React', () => {