feat: create components react package #613
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AndreaBusse29
force-pushed
the
chore/create-components-react-package
branch
from
0b5916a
to
d7009bc
Compare
AndreaBusse29
force-pushed
the
chore/documentation-dir-to-packages
branch
from
3dac57c
to
1d4f0d9
Compare
Robbert
force-pushed
the
chore/documentation-dir-to-packages
branch
2 times, most recently
from
a31ba43
to
79e84e9
Compare
There was a problem hiding this comment.
@hidde @AndreaBusse29 I think to really illustrate the point of the "sparkly button", the button should properly extend the Utrecht button component and expand on its features.
Robbert
changed the title
Robbert
force-pushed
the
chore/create-components-react-package
branch
from
d7009bc
to
6b9081f
Compare
Robbert
force-pushed
the
chore/create-components-react-package
branch
from
6b9081f
to
e8cbbe7
Compare
Robbert
force-pushed
the
chore/create-components-react-package
branch
from
e8cbbe7
to
f06a128
Compare
jest.config.mjs
Outdated
| // transformIgnorePatterns: ['node_modules/(?!@utrecht/web-component-library-react)'], | ||
| }; | ||
|
|
||
| export default createJestConfig(customJestConfig); |
There was a problem hiding this comment.
This file should not be in the root of the project, but in packages/components-react/ where the next and jest dependencies are.
| appearance: { | ||
| control: { type: 'select' }, | ||
| options: [undefined, 'primary-action-button', 'secondary-action-button', 'subtle-button'], | ||
| }, |
There was a problem hiding this comment.
appearance is a property here, but there is no implementation of it in the component. Probably less confusing to not show this in Storybook.
| children: 'Read more...', | ||
| }, | ||
| parameters: { | ||
| tokensPrefix: 'utrecht-button', |
There was a problem hiding this comment.
At first glance I'd say the prefix should be example-button, not utrecht-button.
However, the tokensPrefix is only meaningful when we actually display the tokens, and in Utrecht this is done with a custom component. Since we don't yet support automatic design token docs in the example repo, I think we shouldn't include it here.
| @@ -0,0 +1,84 @@ | |||
| { | |||
| "version": "1.0.0-alpha.0", | |||
There was a problem hiding this comment.
Updated this package to start at alpha.0 instead of alpha.340.
No description provided.