Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move documentation directory to packages #611

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

AndreaBusse29
Copy link
Contributor

No description provided.

@AndreaBusse29 AndreaBusse29 requested a review from a team July 12, 2023 11:55
@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 3:15pm

Copy link
Member

@hidde hidde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ook deze bevat meer changes dan alleen docs directory naar packages; changeset als geheel lokaal getest.

@@ -1,31 +1,26 @@
/* eslint-env node */
module.exports = {
stories: ['../../../documentation/**/*stories.@(js|jsx|mdx|ts|tsx)', '../src/**/*stories.@(js|jsx|mdx|ts|tsx)'],
stories: ['../../documentation/**/*stories.@(js|jsx|mdx|ts|tsx)', '../src/**/*stories.@(js|jsx|mdx|ts|tsx)'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

../../documentation/ can be removed

"@example/design-tokens": "workspace:*",
"@example/documentation": "workspace:*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@example/documentation must be removed, it no longer exists.

@Robbert Robbert force-pushed the chore/documentation-dir-to-packages branch from a31ba43 to 79e84e9 Compare August 7, 2023 15:14
@Robbert Robbert merged commit b2f2ee8 into main Aug 7, 2023
7 checks passed
@Robbert Robbert deleted the chore/documentation-dir-to-packages branch August 7, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants