Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Baseprops #1382

Merged
merged 7 commits into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions components/Accordion/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
},
{
"path": "../Typography"
},
{
"path": "../BaseProps"
}
]
}
3 changes: 0 additions & 3 deletions components/Action/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
{
"path": "../Icons"
},
{
"path": "../BaseProps"
},
{
"path": "../../proprietary/Common"
},
Expand Down
1 change: 0 additions & 1 deletion components/Alert/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"clean": "rimraf dist tsconfig.tsbuildinfo"
},
"dependencies": {
"@gemeente-denhaag/baseprops": "workspace:*",
"@gemeente-denhaag/button": "workspace:*",
"@gemeente-denhaag/iconbutton": "workspace:*",
"@gemeente-denhaag/icons": "workspace:*",
Expand Down
11 changes: 9 additions & 2 deletions components/Alert/src/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import React from 'react';
import BaseProps from '@gemeente-denhaag/baseprops';
import Button from '@gemeente-denhaag/button';
import { Heading4, Paragraph } from '@gemeente-denhaag/typography';
import { AlertTriangleIcon, CheckCircleIcon, CircleInformationIcon, CloseIcon } from '@gemeente-denhaag/icons';
Expand All @@ -8,7 +7,15 @@ import IconButton from '@gemeente-denhaag/iconbutton';
import './index.scss';
import clsx from 'clsx';

export interface AlertProps extends Omit<BaseProps, 'children' | 'classes' | 'tabIndex'> {
export interface AlertProps {
/**
* The id attribute is used to specify a unique id for an HTML element.
*/
id?: string;
/**
* Extend the styles of the component by adding new classes.
*/
className?: string;
/**
* The title of the alert.
*/
Expand Down
3 changes: 0 additions & 3 deletions components/Alert/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
"include": ["src/**/*"],
"exclude": ["dist", "src/**/*.stories.tsx"],
"references": [
{
"path": "../BaseProps"
},
{
"path": "../Icons"
},
Expand Down
3 changes: 0 additions & 3 deletions components/BadgeCounter/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
"references": [
{
"path": "../DotIndicator"
},
{
"path": "../BaseDataDisplayProps"
}
]
}
37 changes: 0 additions & 37 deletions components/BaseDataDisplayProps/package.json

This file was deleted.

29 changes: 0 additions & 29 deletions components/BaseDataDisplayProps/src/index.tsx

This file was deleted.

15 changes: 0 additions & 15 deletions components/BaseDataDisplayProps/tsconfig.json

This file was deleted.

34 changes: 0 additions & 34 deletions components/BaseProps/package.json

This file was deleted.

66 changes: 0 additions & 66 deletions components/BaseProps/src/index.tsx

This file was deleted.

11 changes: 0 additions & 11 deletions components/BaseProps/tsconfig.json

This file was deleted.

3 changes: 1 addition & 2 deletions components/Breadcrumb/src/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import React from 'react';
import BaseProps from '@gemeente-denhaag/baseprops';
import ResponsiveContent from '@gemeente-denhaag/responsive-content';
import { ChevronRightIcon, HouseIcon } from '@gemeente-denhaag/icons';
import { CustomLink } from '@gemeente-denhaag/link';
Expand All @@ -16,7 +15,7 @@ export interface BreadcrumbItemData {
href?: string;
}

export interface BreadcrumbProps extends Omit<BaseProps, 'tabIndex' | 'classNames'> {
export interface BreadcrumbProps {
/**
* The navigation path array of JSON object, which includes a label and url.
*/
Expand Down
3 changes: 0 additions & 3 deletions components/Breadcrumb/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
{
"path": "../Icons"
},
{
"path": "../BaseProps"
},
{
"path": "../../proprietary/Common"
},
Expand Down
3 changes: 0 additions & 3 deletions components/Button/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@
},
"bugs": "https://github.com/nl-design-system/denhaag/issues",
"dependencies": {
"@gemeente-denhaag/baseprops": "workspace:*"
},
"devDependencies": {
"@gemeente-denhaag/icons": "workspace:*"
},
"peerDependencies": {
Expand Down
3 changes: 0 additions & 3 deletions components/Button/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
{
"path": "../Icons"
},
{
"path": "../BaseProps"
},
{
"path": "../../proprietary/Common"
},
Expand Down
3 changes: 0 additions & 3 deletions components/ButtonGroup/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
{
"path": "../Icons"
},
{
"path": "../BaseProps"
},
{
"path": "../../proprietary/Common"
},
Expand Down
3 changes: 0 additions & 3 deletions components/Card/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
"references": [
{
"path": "../Icons"
},
{
"path": "../BaseProps"
}
]
}
3 changes: 0 additions & 3 deletions components/Checkbox/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
"include": ["src/**/*"],
"exclude": ["dist", "src/**/*.stories.tsx"],
"references": [
{
"path": "../BaseProps"
},
{
"path": "../FormControlLabel"
},
Expand Down
6 changes: 1 addition & 5 deletions components/CtaEvent/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,5 @@
},
"include": ["src/**/*"],
"exclude": ["dist", "src/**/*.stories.tsx"],
"references": [
{
"path": "../BaseProps"
}
]
"references": []
}
6 changes: 1 addition & 5 deletions components/Divider/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,10 @@
"clean": "rimraf dist tsconfig.tsbuildinfo"
},
"dependencies": {
"@gemeente-denhaag/basedatadisplayprops": "workspace:*",
"@gemeente-denhaag/baseprops": "workspace:*"
"@gemeente-denhaag/icons": "workspace:*"
},
"peerDependencies": {
"react": "^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@gemeente-denhaag/icons": "workspace:*"
},
"gitHead": "dcf72a9b79266c1ebede35aff4a02dd9121a980f"
}
2 changes: 1 addition & 1 deletion components/Divider/src/index.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import './index.scss';
import clsx from 'clsx';
import './index.scss';

export interface DividerProps extends React.HTMLAttributes<HTMLHRElement> {
/**
Expand Down
3 changes: 0 additions & 3 deletions components/Divider/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
{
"path": "../Icons"
},
{
"path": "../BaseDataDisplayProps"
},
{
"path": "../../proprietary/Components"
},
Expand Down
3 changes: 0 additions & 3 deletions components/DotIndicator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@
"clean": "rimraf dist tsconfig.tsbuildinfo"
},
"dependencies": {
"@gemeente-denhaag/baseprops": "workspace:*"
},
"devDependencies": {
"@gemeente-denhaag/button": "workspace:*"
},
"peerDependencies": {
Expand Down
Loading
Loading