Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tab component refactor #1302

Merged
merged 8 commits into from
Sep 7, 2023
Merged

Conversation

YourivHDenHaag
Copy link
Contributor

@YourivHDenHaag YourivHDenHaag commented Aug 17, 2023

Refactored the Tab component and removed the dependency on Material UI.

Disabled tabs and a mobile overflow wrapper will be added later.

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
denhaag ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 1:41pm

@ghost
Copy link

ghost commented Aug 25, 2023

Looks good, as far as I can see, I don't see anything notable 👍

Copy link
Contributor

@Borai Borai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YourivHDenHaag don't forget to fetch main (pnpm)

components/Tab/src/Tab.tsx Show resolved Hide resolved
@YourivHDenHaag YourivHDenHaag merged commit 9f595fc into main Sep 7, 2023
8 checks passed
@YourivHDenHaag YourivHDenHaag deleted the feature/tab_component_refactor branch September 7, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants