Rewrite Positioning Code #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in preparation for bugfixes and improvements: Positioning shouldn't take zoom and transform into account. Menu shouldn't appear outside of viewport when body is larger than viewport
this implementation is now functionally the same as before, but without using getBoundingClientRect()
this should always calculate the correct bounds for positioning the context menu, even if the body has a transform (even 3D transforms work suprisingly well) or the page is zoomed and/or scrolled. fixes #39
menu could be larger than viewport, minX and minY calculation was wrong when scrolled, event location was wrong when scrolled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct Min/Max Values for the menu's position are now calculated, even when the body has transforms and/or the page is zoomed/scrolled.